feat(mwl): Implement MWL-RS proposal#27
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
clippy found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
feliwir
force-pushed
the
mwwl-proposal
branch
from
35390e5 to
2074957
Compare
nickamzol
added
backend:dimse
feliwir
force-pushed
the
mwwl-proposal
branch
from
2074957 to
d4861da
Compare
feliwir
force-pushed
the
mwwl-proposal
branch
from
d4861da to
ef210c5
Compare
Contributor
Author
|
Since this supplement of the standard we might be able to merge it @nickamzol ? |
nickamzol
approved these changes
Jan 28, 2026
nickamzol
left a comment
nickamzol
left a comment
Member
There was a problem hiding this comment.
I've tested this feature with the worklists plugin for Orthanc and can confirm that the MWL service works.
Thanks!
| wado: Some(Box::new(S3WadoService::new(&config))), | ||
| stow: None, | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Needs mwl for the S3 backend.
Suggested change
| Self { | |
| qido: None, | |
| wado: Some(Box::new(S3WadoService::new(&config))), | |
| stow: None, | |
| mwl: None, | |
| } |
Comment on lines
+35
to
+36
| // There are always at least 10 attributes + the query retrieve level | ||
| let mut attributes = Vec::with_capacity(11); |
Member
There was a problem hiding this comment.
Capacity can be increased to 24 as we have 23 tags in WORKITEM_SEARCH_TAGS.
Suggested change
| // There are always at least 10 attributes + the query retrieve level | |
| let mut attributes = Vec::with_capacity(11); | |
| // There are always at least 23 attributes + the query retrieve level | |
| let mut attributes = Vec::with_capacity(24); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the MWL-RS proposal that was recently opened. See https://www.dicomstandard.org/news-dir/current/docs/sups/sup246.pdf
I'll create this PR as a draft, since the proposal is still work in progress and some things were unclear for me during implementation. However someone else might find this useful.
The service overlaps mostly with QIDO-RS